https://bugzilla.redhat.com/show_bug.cgi?id=1419379 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - Please update to the latest version, 1.4.2. - Please use a more meaningful name for your archive, with: Source0: https://github.com/ilyak/libefp/archive/%{version}/%{name}-%{version}.tar.gz - Please don't mix spaces and tabs (line 7). Choose one on the other. - The library should be versioned: >In cases where upstream ships unversioned .so library (so this is not needed for >plugins, drivers, etc.), the packager MUST try to convince upstream to start >versioning it. > >If that fails due to unwilling or unresposive upstream, the packager may start >versioning downstream but this must be done with caution and ideally only in >rare cases. We don't want to create a library that could conflict with upstream >if they later start providing versioned shared libraries. Under no circumstances >should the unversioned library be shipped in Fedora. See https://fedoraproject.org/wiki/Packaging:Guidelines#Downstream_.so_name_versioning -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx