https://bugzilla.redhat.com/show_bug.cgi?id=1498468 --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Neal Gompa from comment #2) > (In reply to Fabio Valentini from comment #1) > > There are some issues: > > > > 1) The Release tag is wrong, it should be 1%{?dist}, not 0%{?dist}.1 - also > > fix it in the changelog entry. > > > > This will be fixed on import. I always change it to 1%{?dist} on import. OK. > > 2) There are rpmlint warnings that look suspicious. Are you sure the > > symlinks to js libraries are created successfully? The relative symlinks > > containng all those "../" parts look wrong. Why are those not absolute > > paths? And are they supposed to be dangling in the installed package? I > > don't think so. > > > > appstream-generator.x86_64: W: dangling-relative-symlink > > /usr/share/appstream/templates/default/static/js/flot > > ../../../../../../lib/node_modules/flot > > appstream-generator.x86_64: W: dangling-relative-symlink > > /usr/share/appstream/templates/default/static/js/highlight/highlight.pack.js > > ../../../../../../javascript/highlight.js/highlight.pack.js > > appstream-generator.x86_64: W: dangling-relative-symlink > > /usr/share/appstream/templates/default/static/js/jquery/jquery.min.js > > ../../../../../../javascript/jquery/jquery.min.js > > > > These symlinks are supposed to point to dependencies. They should be valid > symlinks on install. The first two do so correctly (no idea why rpmlint complains), but the "jquery.min.js" symlink is broken in the installed package, I just verified that in a rawhide mock root. > > 3) One of the %description lines is too long: > > appstream-generator.x86_64: E: description-line-too-long C repositories. It > > will extract icons, download screenshots, validate and transform > > Will fix on import. OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
