[Bug 1498468] Review Request: appstream-generator - A fast AppStream metadata generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1498468



--- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
There are some issues:

1) The Release tag is wrong, it should be 1%{?dist}, not 0%{?dist}.1 - also fix
it in the changelog entry.

2) There are rpmlint warnings that look suspicious. Are you sure the symlinks
to js libraries are created successfully? The relative symlinks containng all
those "../" parts look wrong. Why are those not absolute paths? And are they
supposed to be dangling in the installed package? I don't think so.

appstream-generator.x86_64: W: dangling-relative-symlink
/usr/share/appstream/templates/default/static/js/flot
../../../../../../lib/node_modules/flot
appstream-generator.x86_64: W: dangling-relative-symlink
/usr/share/appstream/templates/default/static/js/highlight/highlight.pack.js
../../../../../../javascript/highlight.js/highlight.pack.js
appstream-generator.x86_64: W: dangling-relative-symlink
/usr/share/appstream/templates/default/static/js/jquery/jquery.min.js
../../../../../../javascript/jquery/jquery.min.js

3) One of the %description lines is too long:
appstream-generator.x86_64: E: description-line-too-long C repositories. It
will extract icons, download screenshots, validate and transform

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux