[Bug 1368855] Review Request: radare2 - The reverse engineering framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1368855

Peter Lemenkov <lemenkov@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lemenkov@xxxxxxxxx



--- Comment #19 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
(In reply to Lubomir Rintel from comment #17)

> 1.2.) Bundling Javascript
> 
> First thing: shipping pre-built "minified" files is a huge no-no. It is no
> longer free software since it strips the user of the freedom to do their
> modifications (in what GPL refers to as "preferred form") and thus is not
> appropriate for Fedora. Here's the list of "minified" components I've found
> in the source:
> 
> DataTables 1.10.13
> FileSaver.js snapshot
> JointJS 0.9.7
> JointJS 1.0.3
> jQuery 2.0.3
> jQuery 2.2.4
> jquery.layout 1.3.0.rc30.79
> jquery.onoff 0.3.6
> jquery.scrollTo.min.js 2.1.2
> jQuery UI 1.11.4
> jQuery UI context menu plugin 1.11.0
> jQuery UI v1.10.3
> lodash 3.10.1
> material-design-lite 1.1.3
> mdl-selectfield.min.css unknown
> backbone-min.js unknown
> Underscore.js 1.8.3
> 
> Needless to say, this is a huge mess. There's old and redundant versions of
> various libraries present there. It's not clear to me how to fix that.
> Here's what I find to be a good plan on how to proceed:

Frankly speaking we have lots of examples where we allow bundling like that (or
mislooked previously). I also must admit I am guilty as well.

So I wouldn't consider this as a huge blocker really. Still if it can be
unbundled in a foreseeable time, I can only support that. If it blocks
inclusion of radare2 for few months more - I'd allow it (with promise from
maintainer to fix it in a some next build).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux