https://bugzilla.redhat.com/show_bug.cgi?id=1497594 --- Comment #5 from Alex G. <mr.nuke.me@xxxxxxxxx> --- Hi David, And welcome to the evil blue side. It appears your specfile talks two the build system using two separate mechanisms. One is flashrom_cflags environment variable, and the other one is editing the Makefile.* on the-fly. For the sake of readability, you should chose one mechanism and stick to it. I'm not sure if the flashrom buildsystem needs modifications to support this, but since you are the upstream maintainer, I'm certain this is trivial for you to do. > $(echo "VERSION=%{shortcommit}" > Makefile.version) > $(echo "MAN_DATE=$(date -u "+%Y-%m-%d")" >> Makefile.version) This will give the date of whenever a package was built, not when the software was last released/modified, which I assume is the intention of this variable. Different packages (x64, x86, arm ,etc) end up with different values here, because they are not built at the same time. My third point is that I'm not convinced it's good practice to package snapshots. I understand upstream's desire for users to always have the latest git, however, from a package maintainer point of view, we prefer upstream releases over snapshots. If you think that flashrom is adding features at a fast pace, I believe it would be smarter to have upstream releases at shorter intervals. Hope this helps. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
