[Bug 1443429] Review Request: quisk - Software Defined Radio (SDR) software

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1443429

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
Hello,

 - Please update to latest version 4.1.10

 - Use this source so you don't have to update each time:

Source0:        http://james.ahlstrom.name/quisk/%{name}-%{version}.tar.gz

 - # make Python scripts with shebangs executable ⇒ You should instead remove
the shebang from these files:

for lib in $(find %{buildroot}%{python2_sitelib}/%{name} -name '*.py'); do
 sed '1{\@^#!/usr/bin/python@d}' $lib > $lib.new &&
 touch -r $lib $lib.new &&
 mv $lib.new $lib
done

 - please only use one BR per line for clarity

 - Your patch has mostly been included upstream. The folowing:

diff -up quisk-4.1.3/quisk.py.wx-assert quisk-4.1.3/quisk.py
--- quisk-4.1.3/quisk.py.wx-assert    2016-11-30 11:26:59.000000000 -0700
+++ quisk-4.1.3/quisk.py    2017-04-19 02:50:40.476598810 -0600
@@ -1,4 +1,4 @@
-#! /usr/bin/python
+#!/usr/bin/python2

should probably be handled with sed from within the spec:

sed -i '1 s@^#! /usr/bin/python@#!/usr/bin/python2@' quisk.py

 - Source contains BSD code too:

BSD (3 clause)
--------------
quisk-4.1.10/usb/LICENSE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux