https://bugzilla.redhat.com/show_bug.cgi?id=1497549 --- Comment #1 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- > %if 0%{?rhel} < 7 > Group: Applications/Communications > %endif This doesn't make any sense, why do you want to include Group for RHEL7 and below? Also it is wrong because %rhel is not defined on Fedora, so Group tag will be used on Fedora as well. > Source1: https://github.com/tio/tio/releases/download/v%{version}/%{name}-%{version}.tar.xz.asc Why do you include signature, but do not verify archive? > %{!?_licensedir:%global license %%doc} This is not needed --- Apart from above, looks good to me from first glance. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
