https://bugzilla.redhat.com/show_bug.cgi?id=1495004 --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxx> --- Offhand, I see 2 (more) issues in upstream's provided Makefile.in: 1. (MUST) CFLAGS=@CFLAGS@ @DEFS@ -g -Wall -I. -O0 This line disables optimization, either remove the -O0 or provide a good justification to keep it. 2. (MUST) ${INSTALL} -c -s -m 755 bgpq3 ${DESTDIR}@bindir@ the -s there strips the binary, which is why there is no -debuginfo, need to patch out the '-s' 3. (SHOULD) %install section does not need rm -rf $RPM_BUILD_ROOT 4. (SHOULD) patches usually should include a comment saying explicitly what they are for. in this case, it's pretty obvious though 5. (SHOULD) be careful overusing * globs in %files section. In this case, I'd recommend the files be listed explicitly (since the list is small and manageable) %files %{_bindir}/bgpq3 %{_mandir}/man8/bgpq3.8* Otherwise, package is pretty simple and clean, Naming: ok Sources: ok (md5sum verified), a1b8aa3f9d83aaac4c1edf7abeb2845a bgpq3-0.1.31.tgz Scriptlets: n/a License: ok Please address at least MUST items 1,2 and I'll approve your submission -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
