[Bug 1476434] Review Request: bstrlib - Better String Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1476434



--- Comment #14 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> %install
> ...
> make clean

Superfluous and potentially dangerous to clean the build results during
%install.


> cd ${RPM_BUILD_ROOT}%{_libdir}
> ln -sf libbstr.so.%{version} libbstr.so
> ln -sf libbstr.so.%{version} libbstr.so.%{majorver}
> ln -sf libbstr.so.%{version} libbstr.so.%{minorver}
> ln -sf libbstrsafe.so.%{version} libbstrsafe.so
> ln -sf libbstrsafe.so.%{version} libbstrsafe.so.%{majorver}
> ln -sf libbstrsafe.so.%{version} libbstrsafe.so.%{minorver}
> ln -sf libbstrc++.so.%{version} libbstrc++.so
> ln -sf libbstrc++.so.%{version} libbstrc++.so.%{majorver}
> ln -sf libbstrc++.so.%{version} libbstrc++.so.%{minorver}

The cleaner and more convenient solution to that is to run ldconfig on the
buildroot libdir with the right options to make it create the symlinks without
updating runtime linker's cache.


> %check  #rpath is necessay for the compiled tests (which will not appear
> in the built package) to run here because ldconfig haven't run yet.

Not really. Without RPATH you would simply point $LD_LIBRARY_PATH at the
buildroot libdir when running the testsuite.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux