https://bugzilla.redhat.com/show_bug.cgi?id=1487420 --- Comment #7 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- (In reply to Raphael Groner from comment #6) > First of all, some general advices: > > - Drop Group tag, it's obsolete. > > - Replace all occurences of 'Django' with %{pkgname}, why else define a > macro? I'll do this. > > - Why no support for python3? > https://fedoraproject.org/wiki/Packaging:Python > The purpose of this package is for support of Review Board, which is python2 only. I'm trying to make it very clear that I do not intend to maintain other uses of this package (though I'm open to a comaintainer if they want to maintain other use-cases). > - There seems to be a conflict with the virtual provides compared to > python-django package. Would an update remove python-django16 in case > there's > a newer version of python-django itself? Please try to avoid any conflict. > https://fedoraproject.org/wiki/Packaging:Conflicts > It *shouldn't*, but as there's probably no reason to have those virtual provides in this compat package, I'll drop them. > - Can the tests get fixed? Did upstream get poked when version 1.6 was > latest? Upstream never fixed them and I don't see that changing at this point, since it's in security-maintenance-only mode. > > - Use '%license COPYING'. > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text > Whoops! Missed that. Thanks. > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - Package uses either %{buildroot} or $RPM_BUILD_ROOT > Note: Using both %{buildroot} and $RPM_BUILD_ROOT I will correct this. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file LICENSE-JQUERY.txt is not marked as %license > See: > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text I will add this. > - Spec file name must match the spec package %{name}, in the format > %{name}.spec. > Note: python-django.spec should be python-django16.spec > See: > http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name > I will fix it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
