[Bug 1495985] Review Request: libcouchbase - the driver for Couchbase Server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1495985



--- Comment #14 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
> %cmake -DLCB_NO_MOCK=1
> %make_build
Move this to %build section

> %make_install
And this to %install section

There seems to be one more bug.. In pkg-config file you have
> libdir=${prefix}//usr/lib64
Which is wrong =)

---

> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-admin.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-bucket-create.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-bucket-delete.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-cat.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-connstr.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-cp.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-create.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-dsn.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-flush.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-hash.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-lock.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-n1qlback.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-observe.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-pillowfight.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-ping.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-rm.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-role-list.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-stats.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-subdoc.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-unlock.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-user-delete.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-user-list.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-user-upsert.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-verbosity.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-version.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc-view.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man1/cbc.1
> libcouchbase-tools.x86_64: W: manpage-not-compressed gz /usr/share/man/man4/cbcrc.4

> libcouchbase-tools.x86_64: E: explicit-lib-dependency libcouchbase-libevent(x86-64)
Seems to be false-positive.. mind reporting bug to rpmlint?

> libcouchbase-tools.x86_64: W: manual-page-warning /usr/share/man/man1/cbc-pillowfight.1 266: warning: macro `..' not defined
> libcouchbase-tools.x86_64: W: manual-page-warning /usr/share/man/man1/cbc-subdoc.1 317: warning: macro `..' not defined
> libcouchbase-tools.x86_64: W: manual-page-warning /usr/share/man/man1/cbc.1 520: warning: macro `..' not defined
Not a blocker, but would be nice to fix this.

> libcouchbase-libuv.x86_64: W: unstripped-binary-or-object /usr/lib64/libcouchbase/libcouchbase_libuv.so
> libcouchbase-tools.x86_64: W: unstripped-binary-or-object /usr/bin/cbc
> libcouchbase-tools.x86_64: W: unstripped-binary-or-object /usr/bin/cbc-n1qlback
> libcouchbase-tools.x86_64: W: unstripped-binary-or-object /usr/bin/cbc-pillowfight
> libcouchbase-tools.x86_64: W: unstripped-binary-or-object /usr/bin/cbc-proxy
> libcouchbase-tools.x86_64: W: unstripped-binary-or-object /usr/bin/cbc-subdoc
> libcouchbase-libevent.x86_64: W: unstripped-binary-or-object /usr/lib64/libcouchbase/libcouchbase_libevent.so
> libcouchbase-libev.x86_64: W: unstripped-binary-or-object /usr/lib64/libcouchbase/libcouchbase_libev.so
> libcouchbase.x86_64: W: unstripped-binary-or-object /usr/lib64/libcouchbase.so.2.0.49
Seems to be an issue, although I'm not sure how to fix from first glance..

> libcouchbase.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libcouchbase.so.2.0.49 SSL_CTX_set_cipher_list
> libcouchbase.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libcouchbase.so.2.0.49 SSL_CTX_set_cipher_list
I guess you need to patch it more..

I think unstripped-binary and uncompressed manpage issues will go away as soon
as you will create proper %build and %install sections..

===

Anyway, awesome work! Get this things fixed and I'm pretty sure you will get
package in Fedora ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux