Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pinot - Personal search and metasearch for the Desktop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251317 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-08-13 10:32 EST ------- Okay One comment and one rpmlint * desktop-file-install -------------------------------------------------------- desktop-file-install --vendor fedora \ --dir $RPM_BUILD_ROOT%{_datadir}/applications \ $RPM_BUILD_ROOT%{_datadir}/applications/pinot.desktop rm -f $RPM_BUILD_ROOT%{_datadir}/applications/pinot.desktop -------------------------------------------------------- - This can be done by one line: -------------------------------------------------------- desktop-file-install --vendor fedora \ --dir $RPM_BUILD_ROOT%{_datadir}/applications \ --delete-original \ $RPM_BUILD_ROOT%{_datadir}/applications/pinot.desktop -------------------------------------------------------- * rpmlint -------------------------------------------------------- W: pinot macro-in-%changelog files -------------------------------------------------------- - In changelog, use %% (i.e. Fix %%files section) to avoid that % macro is expanded. Please fix the issues above before committing into Fedora CVS. --------------------------------------------------------- This package (pinot) is APPROVED by me --------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review