https://bugzilla.redhat.com/show_bug.cgi?id=1495985 --- Comment #7 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- Hello, unfortunately I can't sponsor you, but I can give you some advises.. --- > %if 0%{?fedora} >= 21 > Recommends: %{name}-libevent%{_isa} = %{version}-%{release} > Suggests: %{name}-libev%{_isa} = %{version}-%{release} > Suggests: %{name}-tools%{_isa} = %{version}-%{release} > Patch0: f21-enforce-system-crypto-policies.patch > %endif Here are 2 issues: 1. You always should include Patch0, regardless whether you will apply it or not 2. The conditional doesn't make sense because F21 is EOL for long time, so I would recommend you to remove this conditional at all > %setup -q -n %{name}-%{version} Note that "-n %{name}-%{version}" is default for %*setup macro, so you can safely remove this. Also I would recommend you to change whole line to "%autosetup" which also would apply patches automatically if you have them (P.S. if you will have problems with applying patches, you might want to add "-p1" after), right now patch is not applied at all > make %{_smp_mflags} V=1 You could replace (and I recommend to) this with %make_build (I don't think that V=1 is also needed because %cmake macro automatically adds -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON to cmake invocation which makes make verbose) > make install DESTDIR="%{buildroot}" AM_INSTALL_PROGRAM_FLAGS="" You could replace (and I recommend to) this with "%make_install" which does absolutely same, not sure about AM_INSTALL_* thing though, but you still can pass it to %make_install > -DLCB_BUILD_LIBUV=OFF Why not to build libuv part as well? We have it in Fedora.. > %post -n %{name} -p /sbin/ldconfig > %postun -n %{name} -p /sbin/ldconfig Consider dropping "-n %{name}" since it is default. --- You miss BuildRequires: gcc and BuildRequires: gcc-c++. You have to list them since your package needs them to build. And you probably want to add soname for libev / libevent libs, not sure how it is supposed to work though (see https://fedoraproject.org/wiki/Packaging:Guidelines#Downstream_.so_name_versioning). === Hope it is useful =) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
