Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pinot - Personal search and metasearch for the Desktop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251317 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-08-13 06:08 EST ------- For -4: (I am still rebuilding -4 srpm, so just checked your spec file) ---------------------------------------------------- @@ -85,6 +108,7 @@ %{_bindir}/pinot-index %{_bindir}/pinot-search %{_datadir}/pinot/ +%{_libdir}/pinot/ %{_libdir}/pinot/filters/libexternalfilter.so* %{_libdir}/pinot/filters/libmboxfilter.so* %{_libdir}/pinot/filters/libtaglibfilter.so* @@ -100,6 +124,7 @@ %{_datadir}/icons/hicolor/24x24/apps/pinot.png %{_datadir}/icons/hicolor/22x22/apps/pinot.png %{_datadir}/icons/hicolor/16x16/apps/pinot.png +%{_sysconfdir}/pinot/ %config(noreplace) %{_sysconfdir}/pinot/external-filters.xml %config(noreplace) %{_sysconfdir}/pinot/globalconfig.xml %config(noreplace) %{_sysconfdir}/pinot/textcat_conf.txt ----------------------------------------------------- - The file entry ----------------------------------------------------- foo/ ----------------------------------------------------- (where foo is the directory) means the directory foo itself and all files/directories/ etc.. under foo/ so this makes duplicate file entries. For %{_libdir}/pinot/, %{_libdir}/pinot/filters/libexternalfilter.so* and on are now not needed. For {_sysconfdir}/pinot/, mark this as %dir, i.e. ------------------------------------------------- %dir %{_sysconfdir}/pinot %config(noreplace) %{_sysconfdir}/pinot/external-filters.xml ......... ------------------------------------------------- or just: ------------------------------------------------- %config(noreplace) %{_sysconfdir}/pinot/ ------------------------------------------------- The latter description contains directory %_sysconfdir/pinot and all files under the directory, and mark all files under %_sysconfdir/pinot as %config(noreplace). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review