https://bugzilla.redhat.com/show_bug.cgi?id=1495968 Bug ID: 1495968 Summary: Review Request: <main package name here> - <short summary here> Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: mgansser@xxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/webvfx.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/webvfx-0.4.5-1.fc26.src.rpm Description: WebVfx is a video effects library that allows effects to be implemented using WebKit HTML or Qt QML. Fedora Account System Username: martinkg rpmlint output: rpmlint -i -v webvfx.spec /home/martin/rpmbuild/SRPMS/webvfx-0.4.5-1.fc26.src.rpm /home/martin/rpmbuild/RPMS/x86_64/webvfx-0.4.5-1.fc26.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/webvfx-devel-0.4.5-1.fc26.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/webvfx-debuginfo-0.4.5-1.fc26.x86_64.rpm webvfx.spec: I: checking webvfx.spec:43: E: hardcoded-library-path in %{_prefix}/lib/libwebvfx.so* A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. webvfx.spec: I: checking-url https://github.com/mltframework/webvfx/archive/master.tar.gz (timeout 10 seconds) webvfx.src: I: checking webvfx.src: I: checking-url https://github.com/mltframework/webvfx/releases (timeout 10 seconds) webvfx.src:43: E: hardcoded-library-path in %{_prefix}/lib/libwebvfx.so* A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. webvfx.src: I: checking-url https://github.com/mltframework/webvfx/archive/master.tar.gz (timeout 10 seconds) webvfx.x86_64: I: checking webvfx.x86_64: I: checking-url https://github.com/mltframework/webvfx/releases (timeout 10 seconds) webvfx.x86_64: W: shared-lib-calls-exit /usr/lib64/libwebvfx.so.1.0.0 _exit@GLIBC_2.2.5 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. webvfx.x86_64: W: no-manual-page-for-binary webvfx_browser Each executable in standard binary directories should have a man page. webvfx.x86_64: W: no-manual-page-for-binary webvfx_render Each executable in standard binary directories should have a man page. webvfx.x86_64: W: no-manual-page-for-binary webvfx_viewer Each executable in standard binary directories should have a man page. webvfx-devel.x86_64: I: checking webvfx-devel.x86_64: I: checking-url https://github.com/mltframework/webvfx/releases (timeout 10 seconds) webvfx-devel.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. webvfx-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. webvfx-debuginfo.x86_64: I: checking webvfx-debuginfo.x86_64: I: checking-url https://github.com/mltframework/webvfx/releases (timeout 10 seconds) webvfx-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/webvfx-master/build/release/.moc The file or directory is hidden. You should see if this is normal, and delete it from the package if not. webvfx-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/webvfx-master/build/release/.moc The file or directory is hidden. You should see if this is normal, and delete it from the package if not. webvfx-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/webvfx-master/build/release/.rcc The file or directory is hidden. You should see if this is normal, and delete it from the package if not. webvfx-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/webvfx-master/build/release/.rcc The file or directory is hidden. You should see if this is normal, and delete it from the package if not. webvfx-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/webvfx-master/build/release/.ui The file or directory is hidden. You should see if this is normal, and delete it from the package if not. webvfx-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/webvfx-master/build/release/.ui The file or directory is hidden. You should see if this is normal, and delete it from the package if not. 4 packages and 1 specfiles checked; 2 errors, 12 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
