https://bugzilla.redhat.com/show_bug.cgi?id=1495295 --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Why do you choose to package git commit 9b7a7002582f1060703aa85bbbe4a422447d0c6e, which corresponds to version 0.4 from 2015, instead of packaging version 0.7 from 6 months ago (git commit fcc1d072d63b3e843495d4af4c0f522ddbb9fefc https://gitweb.torproject.org/pluggable-transports/goptlib.git/tag/?h=0.7 ) Do a normal release of 0.7: %global commit fcc1d072d63b3e843495d4af4c0f522ddbb9fefc %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global commitdate 20170331 Name: golang-%{provider}-%{project}-%{repo} Version: 0.7 Release: 1%{?dist} And the changelog: * Mon Sep 25 2017 Hedayat Vatankhah <hedayat.fwd+rpmchlog@xxxxxxxxx> - 0.7-1 - You've got leftover of siphash in this comment: # The source for this package was pulled from upstream's vcs. Clone the # repository and create archive using: # git archive --format=tar --prefix=goptlib-<commit>/ HEAD | gzip > ***siphash***-<shortcommit>.tar.gz I haven't yet formally reviewed it, but please fix this and I'll continue the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
