Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pinot - Personal search and metasearch for the Desktop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251317 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-08-13 04:24 EST ------- Some notes: * On %build section ---------------------------------------- %configure CFLAGS=$RPM_OPT_FLAGS make ---------------------------------------- - %configure sets CFLAGS and setting CFLAGS environ on make should not be needed. * Directory ownership - Please make it sure that all directory this package creates newly are owned by this package. Currently the following directories are not owned by any packages. ---------------------------------------- %_libdir/pinot/ %_libdir/pinot/filters/ %_sysconfdir/pinot/ ---------------------------------------- * Debuginfo source permission - Currently rpmlint complains a lot against debuginfo rpm like: ---------------------------------------- E: pinot-debuginfo script-without-shebang /usr/src/debug/pinot-0.75/UI/GTK2/src/indexDialog.cc E: pinot-debuginfo script-without-shebang /usr/src/debug/pinot-0.75/UI/GTK2/src/WorkerThreads.cpp ---------------------------------------- This is because the original source codes have inappropritate permission (which must be 0644). * Executable permission v.s. shebang ----------------------------------------- E: pinot-deskbar non-executable-script /usr/lib/deskbar-applet/handlers/pinot-live.py 0644 ----------------------------------------- - This is because this script has shebang (#!/usr/bin/env python) but does not have executable permission. It looks that this script is called by some software and it is not executed directly. So remove shebang from this script. * scriptlets - update of gtk icon cache - (please check "GTK+ icon cache" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ) * Scriptlets are needed even for %postun. * Please make it sure that this script ends with success (i.e. add "|| : " or add "exit 0") -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review