[Bug 1495227] Review Request: perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames - Metaclass trait to attempt to demystify generated anonymous class names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1495227

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please add build-requires 'make'

$ rpm -qp --requires
perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames-0.002003-1.fc28.noarch.rpm
| sort | uniq -c
      1 perl(autobox::Core)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(Moose::Exporter)
      1 perl(Moose::Role)
      1 perl(namespace::autoclean)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides
perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames-0.002003-1.fc28.noarch.rpm
| sort | uniq -c
      1 perl(MooseX::TraitFor::Meta::Class::BetterAnonClassNames) = 0.002003
      1 perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames = 0.002003-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames*
perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames.noarch: W: spelling-error
Summary(en_US) Metaclass -> Meta class, Meta-class, Metacarpals
perl-MooseX-TraitFor-Meta-Class-BetterAnonClassNames.src: W: spelling-error
Summary(en_US) Metaclass -> Meta class, Meta-class, Metacarpals
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux