[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1428202



--- Comment #18 from Raphael Groner <projects.rg@xxxxxxxx> ---
(In reply to Damian Wrobel from comment #16)
> Few comments:
…
> Now when json 3rdparty had been unbundled the BSD part seems to not be
> applicable any longer.

OK

> Based on the build-log and debug-info I see that lxqt-wallet seems to be
> used (the bundled) version. It looks that we have in fedora[1]. Please
> consider to unbundle.

Found some (old & closed) issues in upstream tracker. Therefore not sure if
unbundling is fully supported but CMakeLists.txt has an option, we'll see.
https://github.com/mhogomchungu/sirikali/issues/9
https://github.com/mhogomchungu/sirikali/issues/34
https://github.com/mhogomchungu/sirikali/blob/master/CMakeLists.txt#L75

> As per [2] it would be nice to include appdata (for convenience Debian seems
> to have it, see: [3]).

OK

> [1]. https://admin.fedoraproject.org/pkgdb/package/rpms/lxqt-wallet/
> [2]. https://fedoraproject.org/wiki/Packaging:AppData 
> [3]. https://packages.debian.org/sid/amd64/sirikali/filelist

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux