https://bugzilla.redhat.com/show_bug.cgi?id=1493738 --- Comment #6 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hi Clement, thanks for the quick response. Since you I am sponsoring you, this reply is a little long so I can explain some parts of the packaging guidelines. I did not get to comment about this, but note that this package was retired because it is dead upstream. We usually avoid packaging dead projects in Fedora and when the ones we have die, we retire them. It may be a bad idea to put this back in Fedora, and since you are working directly on the package that requires python-xappy, it would be a great opportunity to remove/replace this dependency. Now, to the package: - All your package Requires and BRs should be versioned. For example, BuildRequires: python-setuptools should be BuildRequires: python2-setuptools After 2020, python-setuptools will point to python3-setuptools and your package will not build. - You can also run your tests with nosetests-2 for the same reasons above. > The upstream used to be on google code, since google decided to retire this > service is not possible to get the release from it anymore. That why I move > the source to pagure. It would be nice to add a comment about that on the specfile. Also, use upstream url for the URL tag (which is google code). I am not sure if this is the best approach here. I will check if there is a better option than just importing the project to pagure in a single commit and then give you some feedback as soon as I get an answer for that. > I believe it still should be 0.6 since it is the version of the upstream and > I indeed raise the release version so that is it greater than the last > release of this package. According to the commits in upstream SVN, they never really released version 0.6.0. The 0.6.0 version variable was set in __setup__.py in SVN commit 565. Check the author's note: "Bump version to 0.6.0 - release won't be for a little while yet, but this allows me to test the version for backward compatibility" 0.6.0-0.1.svn624 was the first Fedora package, the release tag reads 0.1.svn624. It reads 0.1 because the packager wanted to show that this was a pre-release, meaning that the author had not had released this version of the package yet, and it was being shipped anyway. When we ship a pre-release like that, we must show which revision of the VCS we are shipping, that is where the svn624 part enters: it is the number of the SVN commit being packaged for Fedora. The package was updated a few times: 0.6.0-0.2.svn624 [...] 0.6.0-0.10.svn624 0.6.0-0.11 <===== Why is it missing now? You are still packaging a pre-release, so it would be nice to keep the same '.svn624' suffix there, showing whoever uses this package that they are actually using a specific revision of the package, not version 0.6.0 (nor 0.5.0) itself. Read the versioning guidelines if you have any doubts [1]. [1] https://fedoraproject.org/wiki/Packaging:Versioning -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
