Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bandsaw - A syslog monitoring program for the GNOME desktop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234326 ------- Additional Comments From dtimms@xxxxxxxxxxxx 2007-08-11 02:02 EST ------- Damien, have you had a chance to peruse my pre-review ? It is possibly not obvious that for each element listed: .x = Not ok .? = Either I don't understand enough to confirm that the element is acceptable, or I don't understand what the spec is doing. I would request some comment to explain if you believe that item is OK. ./ = tick - OK. No work required. Usually a comment was included after: to describe what I found. If you need bigger hints, please say so in this review request, and I'll try to help. (In reply to comment #7) > .? build dependencies must be listed in BuildRequires: > - no listed BR is in the auto included list, the package built on my system > after yum localinstall the .src.rpm installed lots of -devel rpms. > - yet to try mock build. ./ package builds in mock: see attached build.log On that machine {fedora 7}, the mock built package installs OK. When run as a user I see: $ bandsaw Traceback (most recent call last): File "/usr/bin/bandsaw", line 31, in <module> import egg.trayicon File "/usr/lib/python2.5/warnings.py", line 62, in warn globals) File "/usr/lib/python2.5/warnings.py", line 83, in warn_explicit for item in filters: ImportError: could not import gtk - should the package work when run as a user ? . when run as root: # bandsaw /usr/bin/bandsaw:31: DeprecationWarning: the module egg.trayicon is deprecated; equivalent functionality can now be found in pygtk 2.10 import egg.trayicon As root, I get the config dialog, {after I make the fifo file, and add to the /etc/syslog.conf}, and it then runs the notify icon. Clicking this opens the UI. Even when I cause stuff that gets appended to /var/log/messages, no items are added to the gui. Hence, I can't tell for sure whether it is working OK, what should I be seeing ? {what is good syslog config that gives lots of messages into bandsaw ?} === .x rpm install should be silent: - On my normal machine if I rpmbuild -ba the spec, the resultant yum install: ... Installing: bandsaw i386 0.3.0-2.fc7 /usr/src/redhat/RPMS/i386/bandsaw-0.3.0-2.fc7.i386.rpm 256 k Transaction Summary ============================================================================= Install 1 Package(s) Update 0 Package(s) Remove 0 Package(s) Total download size: 256 k Is this ok [y/N]: y Downloading Packages: Running Transaction Test Finished Transaction Test Transaction Test Succeeded Running Transaction Installing: bandsaw ######################### [1/1] gconfd-2: no process killed Installed: bandsaw.i386 0:0.3.0-2.fc7 Complete! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review