https://bugzilla.redhat.com/show_bug.cgi?id=1493738 Athos Ribeiro <athoscribeiro@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |athoscribeiro@xxxxxxxxx --- Comment #3 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hi Clement, - Why did you move upstream to pagure? Are you forking the project? - Check the python packaging guidelines [1], you are supposed to specify the python version your package is packaged for in the name of the binary packages. If this is a python2 only package, you should only build python2-xappy (in this case, you can rename the package). - Use the macros that support versions. - Use the build and install macros %pyX_build %pyX_install - If that sed command in %prep is removing shebangs from those files, it would be nice to have a comment there saying so, since all the command says is that it is removing the first line of each file. - The license file should be under %license, not %doc - You want to use the %{?dist} tag after the release - It seems that version 0.6 used to be a pre-release (under development), any comments here? Check the version guidelines [3] for pre-releases and make sure your new release is greater than the last one released before this package was retired. - You may remove the Group tag, this is not used in Fedora Checking the example common spec in the python packaging guidelines will help you rewriting this spec file [2]. During this package review, it would be nice if you performed a few informal package reviews (you can post links for them here in this thread) to show us that you can read, understand and apply our packaging guidelines. [1] https://fedoraproject.org/wiki/Packaging:Python [2] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file [3] https://fedoraproject.org/wiki/Packaging:Versioning -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
