[Bug 1491216] Review Request: 5minute - Give me an instance of mine image on OpenStack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1491216



--- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> Release: 1

This should be "Release: 1%{?dist}".
See: https://fedoraproject.org/wiki/Packaging:DistTag

> %global debug_package %{nil}

Remove this, and add "BuildArch: noarch" right above "%description"

The Python modules that you require, you need to BuildRequires them as well, so
that %py3_build will function correctly. They also need to be the Python 3
variants, so use "python3-X" instead of "python-X".

You're also missing a BuildRequires on "python3-devel" and
"python3-setuptools".

> Summary: Give me an instance of mine image on OpenStack. Hurry!

This does not summarize what the tool does.

> %description
> %{summary}

Please put a proper description in here.

> /usr/bin/5minute

Use %{_bindir}/5minute

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux