[Bug 1492866] Review Request: exercism - Exercism command-line interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1492866



--- Comment #2 from Clément DAVID <c.david86@xxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #1)
>  - In the description, https://exercism.io should not be https but http: the
> site is not available in https.

Nice catch ! I added the s blindly.

>  - I've got a build error:
> 
> + go build -o out/exercism exercism/main.go
> go: GOPATH entry is relative; must be absolute path: "".
> For more details see: 'go help gopath'
>   To solve this, I've modified your SPEC like this:
> 
> %prep
> %setup -q -n %{repo}-%{version}
> %patch1 -p1
> 
> %build
> mkdir -p ./_build/src/%{provider}.%{provider_tld}/%{project}
> ln -s $(pwd) ./_build/src/%{provider}.%{provider_tld}/%{project}/cli
> export GOPATH=$(pwd)/_build:%{gopath}
> go build -o out/exercism exercism/main.go

After some investigation, I'm able to reproduce. The 'GOPATH' did not expand to
anything on mock (and on your system). A trailing "" is then resolved as a
relative path. FIXED

>   - Packaging -devel and -unit-test-devel are not needed for a Go binary,
> just keep the main package. Thus you should also remove the Provides: only
> needed if the package is used as a library.

OK, I removed them then and cleaned all the spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux