https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|projects.rg@xxxxxxxx |nobody@xxxxxxxxxxxxxxxxx --- Comment #5 from Raphael Groner <projects.rg@xxxxxxxx> --- First, some general advices: - You can directly link to pushed commits being parts of pull requests. For instance: Patch0: https://github.com/SimonKagstrom/kcov/commit/49b588443ddc6644f728d04af662a6d13d51ecd2.patch - Create a separate bug for each entry of ExcludeArch and let it block the individual tracker. https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures - Please decide if the package is for python2 or python3, maybe both. The executables need to run with the versionized shebang command. BuildRequire: python is not unique about version. https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes https://fedoraproject.org/wiki/Packaging:Python#Avoiding_collisions_between_the_python_2_and_python_3_stacks - Why not unbundle handlebars and jquery? What's the reason for concrete versions as noted? https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries - When above suggestion is applied to add direct links to upstream commits as patches, it's possible to use %autosetup only instead of %setup -q and several %patch lines. https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25prep_section:_.25autosetup_command - Can you be more precise in %files about the file names? It would simplify further updates and 'll show new and lost files. https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_section -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
