https://bugzilla.redhat.com/show_bug.cgi?id=1492794 --- Comment #5 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> --- This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* Artistic", "Unknown or generated", "MIT/X11 (BSD like)", "*No copyright* MPL (v2.0)", "BSD (unspecified)", "BSD (3 clause)", "BSD (2 clause)", "*No copyright* Apache (v2.0)". 1139 files have unknown license. Detailed output of licensecheck in /home/lsm5/repositories/pkgs/reviews/1492794-caddy/licensecheck.txt [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id (libwayland-server, virglrenderer, cyrus-sasl-md5, iputils, spectrwm, cups-client, numactl-libs, nss-tools, gc, policycoreutils-python- utils, gdbm, qemu-block-gluster, gpgme, osinfo-db-tools, rpm-plugin- selinux, xorg-x11-drv-openchrome, libmcpp, neomutt, libibverbs, xorg-x11-server-utils, postgresql-libs, giflib, lua-libs, tk, trousers, qemu-block-nfs, bzip2-libs, xorg-x11-drv-nouveau, unzip, sshpass, libvirt-daemon-driver-xen, libdb-utils, xorg-x11-font-utils, gtk2, gtk3, libcom_err, libseccomp, gnutls, u2f-hidraw-policy, usbredir, p11-kit, iproute, iptables-libs, rpm-build, device-mapper- persistent-data, cryptsetup-libs, ykpers, libmodman, xdotool, libvirt- daemon-driver-nwfilter, xorg-x11-drv-dummy, findutils, parted, mozjs17, bluez-libs, mesa-libwayland-egl, glusterfs, libinput, libwebp, libxslt, libspectre, libpkgconf, libunistring, keyutils-libs, perl-Encode, elfutils, libproxy, libevdev, libgpg-error, lvm2-libs, libosinfo, perl-Digest-SHA, corosync, perl-Data-Dumper, glusterfs- fuse, isns-utils-libs, libcrypt-nss, libsndfile, gawk, python2-rpm, libasyncns, gtk-vnc2, libbasicobjects, c-ares, python2-cairo, zathura- pdf-poppler, rdma-core, jansson, vte291, e2fsprogs-libs, pulseaudio- libs, librsvg2, firefox, lcms2, qemu-block-iscsi, libnfsidmap, libsss_nss_idmap, deltarpm, libXrandr, grub2-tools, libxcb, trousers- lib, libyubikey, avahi-glib, python3-pycurl, tar, zip, libnetfilter_conntrack, webrtc-audio-processing, startup-notification, m4, gdb-headless, yum-metadata-parser, libusbx, python3-PyYAML, poppler-glib, compat-openssl10, xorg-x11-drv-fbturbo, qrencode-libs, libICE, drpm, xcb-util, dmenu, createrepo_c-libs, libesmtp, libtasn1, speexdsp, alsa-utils, sqlite, http-parser, iscsi-initiator-utils- iscsiuio, xcb-util-wm, clamav-lib, sudo, iproute-tc, atk, dhcp-client, libvirt-daemon-driver-lxc, libgomp, gcc, systemd-bootchart, libkadm5, dwz, alsa-lib, file-libs, links, xorg-x11-drv-qxl, bluez-cups, ostree- libs, python2-gobject, ebtables, libvirt-daemon-driver-storage-disk, avahi-libs, seamonkey, NetworkManager, pyliblzma, ncurses-libs, libidn2, libxshmfence, xterm-resize, libvirt-daemon-driver-vbox, pigz, xorg-x11-drv-ivtv, python3-gpg, checkpolicy, libpsl, xorg-x11-xkb- utils, libxkbfile, python3-rpm, pciutils, libini_config, scrot, openssh-clients, libuser, perl-libs, libnotify, celt051, kbd, libvirt- daemon-driver-qemu, clamav, xorg-x11-drv-voodoo, qemu-block-ssh, python3-cryptography, systemd, clamav-update, gssproxy, atkmm, libacl, libwayland-cursor, xorg-x11-drv-ati, libnl3, libcap-ng, libSM, policycoreutils, harfbuzz, chromium-libs, zathura-djvu, libidn, npth, xorg-x11-drv-vesa, libwacom, grubby, minizip, python2-kerberos, brltty, pango, texlive-lib, libss, libbabeltrace, nspr, esmtp, e2fsprogs, dbus, libyaml, qemu-block-rbd, polkit-libs, psmisc, net- snmp-libs, perl-threads, perl-Params-Validate, xorg-x11-drv-libinput, pangomm, hostname, libvirt-daemon-driver-storage-sheepdog, python2-libcomps, redhat-lsb-core, ed, mesa-libxatracker, cyrus-sasl- gs2, audit-libs, cyrus-sasl-devel, nss-sysinit, bluez, libgcc, libvirt-daemon-driver-storage-iscsi, gstreamer1, gettext-libs, p11 -kit-trust, nss-mdns, golang-github-cpuguy83-go-md2man, gmime30, python3-cffi, poppler, dbus-libs, djvulibre-libs, cairo-gobject, sheepdog, containernetworking-cni, at-spi2-core, libvirt-daemon- driver-network, sbc, qemu-img, rtkit, usermode, orc, bash, glibc- common, liblockfile, qpdf-libs, linux-atm-libs, libedit, polkit, openssh, libuuid, openssl, libarchive, cyrus-sasl-sql, isl, perl-Net- SSLeay, perl-Scalar-List-Utils, libsss_certmap, cryptsetup, lvm2, mesa-libGLU, python2-alsa, xz, libXcomposite, python3-libs, criu, libnfs, cups, gtk-update-icon-cache, vim-minimal, gstreamer1-plugins- base, tor, tokyocabinet, zathura-ps, python3-librepo, NetworkManager- libnm, urlview, libvirt-daemon-driver-interface, libiscsi, python2-libs, gomtree, libvirt-daemon-driver-libxl, glusterfs-libs, groff-base, libdatrie, spice-server, gdk-pixbuf2, svgalib, authconfig, libunwind, unbound-libs, libevent, python2-cccolutils, libtalloc, libldb, grep, guile, pcre-utf16, libepoxy, gnupg, libvirt-daemon- driver-nodedev, libcanberra, libxkbcommon, cronie-anacron, xfsprogs, man-db, libcroco, libvirt-daemon-driver-storage-core, librdmacm, libgudev, dconf, xz-libs, xorg-x11-drv-wacom, mesa-libgbm, timedatex, xorg-x11-drv-v4l, perl-Package-Stash-XS, python3-dbus, colord-libs, skopeo, which, libcap, libvirt-daemon-driver-storage-zfs, xorg-x11 -drv-sisusb, sssd-nfs-idmap, cyrus-sasl-ntlm, wireless-tools, libdb, passwd, quota, kmod-libs, libvirt-daemon-driver-storage-gluster, gvnc, desktop-file-utils, libXdamage, cronie, autogen-libopts, rpm-libs, python2-krbv, brlapi, libthai, createrepo_c, fakeroot, gtkmm30, libcacard, libverto-libev, keyutils, python2-cryptography, lmdb-libs, libpipeline, libusb, mesa-libGL, tolua++, libtirpc, python2-gpg, libsmartcols, popt, vim-common, python2-xpyb, fakeroot-libs, libsss_idmap, gobject-introspection, libpwquality, libwsman1, rxvt- unicode, fontconfig, krb5-workstation, python3-hawkey, os-prober, jbigkit-libs, iptables, mcpp, freetype, libX11, systemd-libs, cpio, libfdt, xapian-core-libs, rest, lz4-libs, spice-glib, util-linux, libdaemon, mariadb-connector-c, NetworkManager-wifi, xlockmore, libXfont, patch, krb5-libs, runc, rpm-build-libs, audit-libs-python3, net-tools, lttng-ust, libvorbis, enchant, pkgconf, rpcbind, pcre-cpp, python3-libselinux, rhash, libwayland-client, libpciaccess, sed, libipt, libsss_autofs, json-c, perl-threads-shared, glib-networking, libaio, kmod, initscripts, notmuch, device-mapper, python2-librepo, libXtst, kpartx, libpng, ghostscript-core, xorg-x11-xauth, sssd- client, bluez-hcidump, GeoIP, screen, libvirt-daemon-driver-uml, llvm- libs, hardlink, libsigc++20, libcollection, libgcrypt, libpcap, pulseaudio-module-bluetooth, xorg-x11-drv-geode, libvirt-libs, connect-proxy, cairomm, perl-Unicode-UTF8, yajl, zathura-cb, nss- softokn, crda, libXft, libical, at-spi2-atk, libattr, poppler-utils, perl-Variable-Magic, libref_array, qemu-block-curl, gnupg2-smime, libXfont2, rpm, xorg-x11-server-Xorg, torsocks, python3-libcomps, gnupg2, libXcursor, snappy, glibmm24, gpgme-devel, godep, dracut, glib2-devel, libXScrnSaver, radvd, cracklib, procps-ng, ncurses, libdnf, nfs-utils, graphite2, libselinux-utils, python3-kerberos, libXpm, imlib2, zathura-pdf-mupdf, glusterfs-cli, perl-PathTools, libtdb, ipset-libs, cri-o, bluez-obexd, pulseaudio-libs-glib2, zlib, bluez-tools, avahi, libselinux, cdparanoia-libs, at, glusterfs-client- xlators, tripwire, ncurses-compat-libs, libassuan, alsa-tools, libxml2, expat, cups-filters, iw, python3-setools, userspace-rcu, perl-interpreter, chkconfig, cyrus-sasl-gssapi, xorg-x11-drv- synaptics-legacy, chromium-libs-media, libcurl, make, libvirt-daemon, libseccomp-devel, giblib, iscsi-initiator-utils, coreutils, gnutls- utils, libsecret, dbus-glib, librados2, libvirt-daemon-driver-storage- mpath, dbus-x11, pam, libnet, cyrus-sasl, libatomic_ops, lzop, python2-cffi, glusterfs-api, pinentry, libvirt-daemon-driver-storage- scsi, openldap, augeas-libs, perl-Filter, librepo, libXxf86misc, fltk, audit, cups-filters-libs, cups-libs, ipcalc, gdk-pixbuf2-modules, binutils, libsepol, gzip, qemu-common, xen-libs, gsm, libuv, libtevent, nss-pem, libvirt-daemon-driver-storage-logical, irssi, lzo, less, libfdisk, libvpx, tcl, cyrus-sasl-ldap, libnghttp2, libsamplerate, python2-lxml, libglvnd, openssl-libs, util-linux-user, libsolv, libxkbcommon-x11, zfs-fuse, python3, gmp, perl-Unicode- Normalize, libXdmcp, gperftools-libs, ipset, libxdo, xterm, perl- Socket, elfutils-libelf, libdrm, polkit-pkla-compat, libvisual, pcre2, jbig2dec-libs, python2, cyrus-sasl-lib, libpath_utils, fuse-libs, python3-gobject-base, perl-TermReadKey, dnsmasq, protobuf-c, perl- MIME-Base64, libXfixes, shared-mime-info, libglvnd-glx, corosynclib, girara, SDL2, libblkid, zathura, libXrender, json-glib, libsss_sudo, libX11-xcb, libfontenc, libicu, xorg-x11-drv-vmware, GConf2, sssd- common, bluez-hid2hci, chromium, glibc, nmap-ncat, btrfs-progs, shadow-utils, perl-IO, bind99-libs, libcgroup, pavucontrol, perl- Params-Util, libXaw, libXau, fipscheck, netcf-libs, bc, xorg-x11-drv- evdev, libssh2, libvirt-client, dmidecode, mesa-libglapi, libXinerama, wget, vim-enhanced, xcb-util-keysyms, elfutils-libs, libjpeg-turbo, spice-gtk3, rpm-plugin-systemd-inhibit, numad, acl, libmount, libvirt- daemon-driver-secret, cyrus-sasl-scram, xorg-x11-drv-fbdev, libgusb, glib2, libqb, python2-libxml2, qemu-system-x86-core, libtiff, wpa_supplicant, python3-libsemanage, libev, libstdc++, libtool-ltdl, libmnl, nss, libsoup, libXxf86vm, dhcp-libs, pcre, git, ima-evm-utils, tcp_wrappers-libs, systemd-pam, python2-libvirt, opus, spax, libverto, cairo, git-core, python2-gobject-base, python3-tkinter, perl-Storable, perl-Digest-MD5, pciutils-libs, grub2-tools-extra, cyrus-sasl-plain, libmpc, openssh-server, libXi, openjpeg2, flac-libs, libXt, libXv, libXext, policycoreutils-devel, libtheora, info, libnfnetlink, bridge- utils, ostree, attr, perl-Sort-Key, device-mapper-event-libs, libvirt- daemon-driver-storage-rbd, nss-util, libcanberra-gtk2, libcanberra- gtk3, device-mapper-event, hunspell, libsemanage, libsigsegv, libndp, mtdev, systemd-container, libcomps, mailx, systemd-udev, xorg-x11-drv- intel, golang, qemu-block-dmg, file, libXvMC, curl, jsoncpp, nettle, bzip2, libssh, cmake, gnutls-dane, sqlite-libs, libXmu, gettext, soxr, nss-softokn-freebl, fipscheck-lib, jasper-libs, pyxattr, librbd1, libdhash, python2-pycurl, libutempter, device-mapper-libs, xorg-x11-xinit, libogg, libmetalink, xorg-x11-drv-amdgpu, libffi, readline, pcre-utf32, python2-hawkey, diffutils, pulseaudio, fuse, chrony, grub2-tools-minimal, time, cpp, perl-version, libksba, mpfr), /usr/lib/.build-id/31(poppler-utils, glibc, systemd-libs, pulseaudio, gettext, golang, gstreamer1-plugins-base, brltty, cpp, python2-gobject, util-linux, gstreamer1) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define gobuild(o:) go build -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \\n')" -a -v -x %{?**}; [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: caddy-0.10.9-4.fc28.x86_64.rpm caddy-0.10.9-4.fc28.src.rpm caddy.x86_64: W: unstripped-binary-or-object /usr/bin/caddy caddy.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/caddy/README.txt caddy.x86_64: W: non-standard-uid /var/lib/caddy caddy caddy.x86_64: W: non-standard-gid /var/lib/caddy caddy caddy.x86_64: E: non-standard-dir-perm /var/lib/caddy 750 caddy.x86_64: W: no-manual-page-for-binary caddy caddy.src:52: W: unversioned-explicit-provides webserver 2 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory caddy.x86_64: W: invalid-url URL: https://caddyserver.com <urlopen error [Errno -2] Name or service not known> caddy.x86_64: W: unstripped-binary-or-object /usr/bin/caddy caddy.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/caddy/README.txt caddy.x86_64: W: non-standard-uid /var/lib/caddy caddy caddy.x86_64: W: non-standard-gid /var/lib/caddy caddy caddy.x86_64: E: non-standard-dir-perm /var/lib/caddy 750 caddy.x86_64: W: no-manual-page-for-binary caddy 1 packages and 0 specfiles checked; 1 errors, 6 warnings. Requires -------- caddy (rpmlib, GLIBC filtered): /bin/sh config(caddy) libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) systemd Provides -------- caddy: caddy caddy(x86-64) config(caddy) webserver Source checksums ---------------- https://github.com/xenolf/lego/archive/49b9503635ff26b2b725667de187f05d5960acd0/lego-49b9503635ff26b2b725667de187f05d5960acd0.tar.gz : CHECKSUM(SHA256) this package : 80edc6c64ce8cb5d826d5d320c98bd06b40b190159157d198a890e36420fdaaf CHECKSUM(SHA256) upstream package : 80edc6c64ce8cb5d826d5d320c98bd06b40b190159157d198a890e36420fdaaf https://github.com/captncraig/caddy-realip/archive/5dd1f4047d0f649f21ba9f8d7e491d712be9a5b0/realip-5dd1f4047d0f649f21ba9f8d7e491d712be9a5b0.tar.gz : CHECKSUM(SHA256) this package : 135e8f15b42d2b6562872756700b9d2163b1e9cc96c4bb6b961a03ef9f76e4d6 CHECKSUM(SHA256) upstream package : 135e8f15b42d2b6562872756700b9d2163b1e9cc96c4bb6b961a03ef9f76e4d6 https://github.com/mholt/caddy/archive/v0.10.9/caddy-0.10.9.tar.gz : CHECKSUM(SHA256) this package : be70a4324e3f6cd4da5e379b31562d07f40f6e39439c7274d4bb94fe482b86e4 CHECKSUM(SHA256) upstream package : be70a4324e3f6cd4da5e379b31562d07f40f6e39439c7274d4bb94fe482b86e4 https://github.com/caddyserver/dnsproviders/archive/8c9fc0487be7ce4d5cfa6f509c58150033eaa23e/dnsproviders-8c9fc0487be7ce4d5cfa6f509c58150033eaa23e.tar.gz : CHECKSUM(SHA256) this package : ff1d69b5cdf865915c817d8188f92234aec98db05afceec89cd3e2686f21a44e CHECKSUM(SHA256) upstream package : ff1d69b5cdf865915c817d8188f92234aec98db05afceec89cd3e2686f21a44e Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1492794 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
