https://bugzilla.redhat.com/show_bug.cgi?id=1485458 --- Comment #11 from Dave Love <dave.love@xxxxxxxxxxxxxxxx> --- Somewhat late, these are comments partly as a user and partly as a packager (which may duplicate the reviewer's somewhat). I've put an updated version of what I ran on an HPC system previously at <http://loveshack.fedorapeople.org/reviews/orangefs>. It's probably not packaging standard, but it has things like support for dkms and multiple transports -- I'd expect openib support for HPC -- and addresses some of these comments. HTH. * Use correct svn Version and Source forms * Use ./prepare in %prep on straight exported source * Use unbundled lmdb (see patch) * Use interface-related soname (see patch); the interface was sufficiently stable over some previous versions I checked with abipkgdiff to keep a major version. * It needs an IB version (unless you can configure for both IB and TCP now) * Probably should have combinatorial builds over network and security types too * Remove the Provides: (but combinatorial builds should maybe provide "orangefs") * Make -libs-<transport> packages for use with mpi-io etc. * Fix strange aarch64-specific build failure, but conditionalize it for now -- ask about it on devel list? src/client/usrint/pvfs-path.c: In function 'PVFS_expand_path': src/client/usrint/pvfs-path.c:266:25: error: 'SYS_readlink' undeclared (first use in this function); did you mean 'SYS_readlinkat'? n = syscall(SYS_readlink, ^~~~~~~~~~~~ SYS_readlinkat * Configure --disable-static * -devel should have Requires, but not the Provides * Install service file correctly, but provide init file for el6 * Don't try to configure the server/client; just provide -example files * Add %licence with correct contents * Expand description? * Cosmetic: Order of stanzas is confusing (e.g. %changelog is conventionally at end) * Build Java, and possibly web, stuff. Any reason not to --enable-fuse ? * Include pacemaker stuff * pvfs2-{start,stop}-all should be %config as they need editing? * Ship examples and built doc * Don't mark %mandir as %doc * Fix the build upstream to be smp-safe: currently tends to fail in statecomp/scanner directory -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
