https://bugzilla.redhat.com/show_bug.cgi?id=1492002 --- Comment #1 from Michael Simacek <msimacek@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: http://fedoraproject.org/wiki/Packaging:Java#Pre- built_JAR_files_.2F_Other_bundled_software' - The test JARs are IMO ok, but there's still gradle-wrapper - Missing BR on maven-plugin-bundle - Invalid license ASL v2.0 ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* EPL (v2.0)", "MIT/X11 (BSD like)", "*No copyright* EPL (v2.0) Apache (v2.0)", "EPL (v2.0)", "*No copyright* MIT/X11 (BSD like)", "*No copyright* Apache (v2.0)". 208 files have unknown license. Detailed output of licensecheck in /home/msimacek/reviews/1492002-junit5/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 645120 bytes in 25 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in junit5-javadoc , junit5-guide [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [!]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: junit5-5.0.0-1.fc28.noarch.rpm junit5-javadoc-5.0.0-1.fc28.noarch.rpm junit5-guide-5.0.0-1.fc28.noarch.rpm junit5-5.0.0-1.fc28.src.rpm junit5.noarch: W: spelling-error %description -l en_US JUnit -> J Unit, Unit, Jun it junit5.noarch: W: invalid-license ASL v2.0 junit5.noarch: W: no-documentation junit5.noarch: W: no-manual-page-for-binary junit5 junit5-javadoc.noarch: W: invalid-license ASL v2.0 junit5-guide.noarch: W: spelling-error %description -l en_US JUnit -> J Unit, Unit, Jun it junit5-guide.noarch: W: invalid-license ASL v2.0 junit5-guide.noarch: W: dangling-relative-symlink /usr/share/doc/junit5-guide/api ../../javadoc/junit5 junit5.src: W: spelling-error %description -l en_US JUnit -> J Unit, Unit, Jun it junit5.src: W: invalid-license ASL v2.0 4 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory junit5.noarch: W: spelling-error %description -l en_US JUnit -> J Unit, Unit, Jun it junit5.noarch: W: invalid-license ASL v2.0 junit5.noarch: W: no-documentation junit5.noarch: W: no-manual-page-for-binary junit5 junit5-guide.noarch: W: spelling-error %description -l en_US JUnit -> J Unit, Unit, Jun it junit5-guide.noarch: W: invalid-license ASL v2.0 junit5-guide.noarch: W: dangling-relative-symlink /usr/share/doc/junit5-guide/api ../../javadoc/junit5 junit5-javadoc.noarch: W: invalid-license ASL v2.0 3 packages and 0 specfiles checked; 0 errors, 8 warnings. Requires -------- junit5 (rpmlib, GLIBC filtered): /bin/bash java-headless javapackages-tools mvn(com.univocity:univocity-parsers) mvn(junit:junit) mvn(net.sf.jopt-simple:jopt-simple) mvn(org.opentest4j:opentest4j) junit5-guide (rpmlib, GLIBC filtered): junit5-javadoc junit5-javadoc (rpmlib, GLIBC filtered): javapackages-tools Provides -------- junit5: junit5 mvn(org.junit.jupiter:junit-jupiter-api) mvn(org.junit.jupiter:junit-jupiter-api:pom:) mvn(org.junit.jupiter:junit-jupiter-engine) mvn(org.junit.jupiter:junit-jupiter-engine:pom:) mvn(org.junit.jupiter:junit-jupiter-migrationsupport) mvn(org.junit.jupiter:junit-jupiter-migrationsupport:pom:) mvn(org.junit.jupiter:junit-jupiter-params) mvn(org.junit.jupiter:junit-jupiter-params:pom:) mvn(org.junit.platform:junit-platform-commons) mvn(org.junit.platform:junit-platform-commons:pom:) mvn(org.junit.platform:junit-platform-console) mvn(org.junit.platform:junit-platform-console-standalone) mvn(org.junit.platform:junit-platform-console-standalone:pom:) mvn(org.junit.platform:junit-platform-console:pom:) mvn(org.junit.platform:junit-platform-engine) mvn(org.junit.platform:junit-platform-engine:pom:) mvn(org.junit.platform:junit-platform-gradle-plugin) mvn(org.junit.platform:junit-platform-gradle-plugin:pom:) mvn(org.junit.platform:junit-platform-launcher) mvn(org.junit.platform:junit-platform-launcher:pom:) mvn(org.junit.platform:junit-platform-runner) mvn(org.junit.platform:junit-platform-runner:pom:) mvn(org.junit.platform:junit-platform-suite-api) mvn(org.junit.platform:junit-platform-suite-api:pom:) mvn(org.junit.platform:junit-platform-surefire-provider) mvn(org.junit.platform:junit-platform-surefire-provider:pom:) mvn(org.junit.vintage:junit-vintage-engine) mvn(org.junit.vintage:junit-vintage-engine:pom:) osgi(org.junit.jupiter.api) osgi(org.junit.jupiter.engine) osgi(org.junit.jupiter.migrationsupport) osgi(org.junit.jupiter.params) osgi(org.junit.platform.commons) osgi(org.junit.platform.console) osgi(org.junit.platform.console.standalone) osgi(org.junit.platform.engine) osgi(org.junit.platform.gradle.plugin) osgi(org.junit.platform.launcher) osgi(org.junit.platform.runner) osgi(org.junit.platform.suite.api) osgi(org.junit.platform.surefire.provider) osgi(org.junit.vintage.engine) junit5-guide: junit5-guide junit5-javadoc: junit5-javadoc Source checksums ---------------- https://repo1.maven.org/maven2/org/junit/platform/junit-platform-runner/1.0.0/junit-platform-runner-1.0.0.pom : CHECKSUM(SHA256) this package : 929814bd71ceb70d5d82dac3ef9bb31cd6e00211307248cb5435b2bd1b661761 CHECKSUM(SHA256) upstream package : 929814bd71ceb70d5d82dac3ef9bb31cd6e00211307248cb5435b2bd1b661761 https://repo1.maven.org/maven2/org/junit/platform/junit-platform-suite-api/1.0.0/junit-platform-suite-api-1.0.0.pom : CHECKSUM(SHA256) this package : c9d979f35ad4d9697f6e543126342b20b31f90b572eb24a261e14e009b8835ae CHECKSUM(SHA256) upstream package : c9d979f35ad4d9697f6e543126342b20b31f90b572eb24a261e14e009b8835ae https://repo1.maven.org/maven2/org/junit/platform/junit-platform-gradle-plugin/1.0.0/junit-platform-gradle-plugin-1.0.0.pom : CHECKSUM(SHA256) this package : bd47b2ebfd9267eff6ac644b47b31661cdf09326cf59e6f2b5c781a9782531e1 CHECKSUM(SHA256) upstream package : bd47b2ebfd9267eff6ac644b47b31661cdf09326cf59e6f2b5c781a9782531e1 https://repo1.maven.org/maven2/org/junit/platform/junit-platform-launcher/1.0.0/junit-platform-launcher-1.0.0.pom : CHECKSUM(SHA256) this package : ee8d72b5283c34e1bb12dd9d319b4a9a489bedc538154918512cf840e01bef45 CHECKSUM(SHA256) upstream package : ee8d72b5283c34e1bb12dd9d319b4a9a489bedc538154918512cf840e01bef45 https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.0.0/junit-platform-console-standalone-1.0.0.pom : CHECKSUM(SHA256) this package : e080fe534e4c77a1476a0edfe908c25611a16e844a281864962aa9e1be3ef592 CHECKSUM(SHA256) upstream package : e080fe534e4c77a1476a0edfe908c25611a16e844a281864962aa9e1be3ef592 https://repo1.maven.org/maven2/org/junit/platform/junit-platform-engine/1.0.0/junit-platform-engine-1.0.0.pom : CHECKSUM(SHA256) this package : 2169ff7bb7305e3964d91eefef113005591d957232ed8dc63bd6901c7e52d1ca CHECKSUM(SHA256) upstream package : 2169ff7bb7305e3964d91eefef113005591d957232ed8dc63bd6901c7e52d1ca https://repo1.maven.org/maven2/org/junit/platform/junit-platform-commons/1.0.0/junit-platform-commons-1.0.0.pom : CHECKSUM(SHA256) this package : 6f1b1a8fdff0a967aaa525afabc427b53c319bf8fabab1f544669a4ee1c54dd3 CHECKSUM(SHA256) upstream package : 6f1b1a8fdff0a967aaa525afabc427b53c319bf8fabab1f544669a4ee1c54dd3 https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console/1.0.0/junit-platform-console-1.0.0.pom : CHECKSUM(SHA256) this package : 8b9fc2bda41f6dfb1ff07a538f6f89c836a95a0b76794a38a7898fab342163e4 CHECKSUM(SHA256) upstream package : 8b9fc2bda41f6dfb1ff07a538f6f89c836a95a0b76794a38a7898fab342163e4 https://repo1.maven.org/maven2/org/junit/jupiter/junit-jupiter-params/5.0.0/junit-jupiter-params-5.0.0.pom : CHECKSUM(SHA256) this package : 188af3bffd8840a8b7b71b8f78f341d25d8007ce8260c795d281e2ca77bfa538 CHECKSUM(SHA256) upstream package : 188af3bffd8840a8b7b71b8f78f341d25d8007ce8260c795d281e2ca77bfa538 https://repo1.maven.org/maven2/org/junit/jupiter/junit-jupiter-migrationsupport/5.0.0/junit-jupiter-migrationsupport-5.0.0.pom : CHECKSUM(SHA256) this package : a43d02a2e4f51fabbab4762f0c003138a6aa18e36a8a2726b93be76e6649c10d CHECKSUM(SHA256) upstream package : a43d02a2e4f51fabbab4762f0c003138a6aa18e36a8a2726b93be76e6649c10d https://repo1.maven.org/maven2/org/junit/jupiter/junit-jupiter-engine/5.0.0/junit-jupiter-engine-5.0.0.pom : CHECKSUM(SHA256) this package : d423a5f638791fc963a8f9c95bf389f3a81b20bed860b633619b35166e4f9843 CHECKSUM(SHA256) upstream package : d423a5f638791fc963a8f9c95bf389f3a81b20bed860b633619b35166e4f9843 https://repo1.maven.org/maven2/org/junit/platform/junit-platform-surefire-provider/1.0.0/junit-platform-surefire-provider-1.0.0.pom : CHECKSUM(SHA256) this package : aee6f30d44443cabcc90c4d3aaa9b1d06ac8c5184db0d0d6205bdb5bac390af5 CHECKSUM(SHA256) upstream package : aee6f30d44443cabcc90c4d3aaa9b1d06ac8c5184db0d0d6205bdb5bac390af5 https://repo1.maven.org/maven2/org/junit/vintage/junit-vintage-engine/4.12.0/junit-vintage-engine-4.12.0.pom : CHECKSUM(SHA256) this package : 773445b6bff10c3ee63c86fc4c0261644a53f5394db5d7743b9c305201b85b2c CHECKSUM(SHA256) upstream package : 773445b6bff10c3ee63c86fc4c0261644a53f5394db5d7743b9c305201b85b2c https://github.com/junit-team/junit5/archive/r5.0.0.tar.gz : CHECKSUM(SHA256) this package : cb03284dcabc32af2b864548940ec3f5f9b2695ddb600a70d96dbdea99c26d26 CHECKSUM(SHA256) upstream package : cb03284dcabc32af2b864548940ec3f5f9b2695ddb600a70d96dbdea99c26d26 https://repo1.maven.org/maven2/org/junit/jupiter/junit-jupiter-api/5.0.0/junit-jupiter-api-5.0.0.pom : CHECKSUM(SHA256) this package : cae10e904f5eafecc4fcb1858f924a1af25a46abc9298e5f2b1aeeb1d3a3554e CHECKSUM(SHA256) upstream package : cae10e904f5eafecc4fcb1858f924a1af25a46abc9298e5f2b1aeeb1d3a3554e Jar and class files in source ----------------------------- ./junit5-r5.0.0/gradle/wrapper/gradle-wrapper.jar ./junit5-r5.0.0/junit-vintage-engine/src/test/resources/vintage-testjar.jar ./junit5-r5.0.0/junit-jupiter-engine/src/test/resources/jupiter-testjar.jar ./junit5-r5.0.0/platform-tests/src/test/resources/folder with spaces/jar test with spaces.jar ./junit5-r5.0.0/platform-tests/src/test/resources/jartest.jar Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1492002 Buildroot used: rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
