[Bug 1491714] Review Request: linuxcnc - CNC Machine Controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1491714



--- Comment #2 from Lubomir Rintel <lkundrak@xxxxx> ---
Thanks

(In reply to Robert-André Mauchin from comment #1)
> Hello,
> 
> 
>  - Group: is not used in Fedora. See:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
> 
>  - There's a typo in Source0: ${name} should be %{name}
> 
>  - Also you can simplify your Source0: like this:
> 
> Source0:       
> https://github.com/LinuxCNC/%{name}/archive/v%{version}/%{name}-%{version}.
> tar.gz
>  
>  - You should provide a -doc subpackage:
> 
>   Large documentation must go in a -doc subpackage. Large could be size
>   (~1MB) or number of files.
>   Note: Documentation size is 5621760 bytes in 966 files.
>   See:
>   http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

Done.

>  - You should provide a systemd service file instead of a init.d script.

This would be non-trivial. I instead move it to %doc, since it's not really
useful with Fedora kernel.

>  - There are too much rpmlint errors to list them here, I suggest you run
> rpmlint on your end and fix the errors.
> 
>     * For example there are plenty of incorrect-fsf-address files, you
> should patch them with the correct address.
> https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
>     * Remove shebang from Python file:
> https://fedoraproject.org/wiki/
> Packaging_tricks#Remove_shebang_from_Python_libraries
>     * A setuid-binary /usr/bin/rtapi_app root 4755

I attempted to fix the most important ones, notably the ones you mention.

The FSF address thing has been reported and fixed upstream:
https://github.com/LinuxCNC/linuxcnc/pull/331

New package:

SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/lkundrak/cnc/linuxcnc.git/plain/linuxcnc.spec?id=d58629efead63f0d7915cee94ece1833b0083eb6
SRPM:
https://copr-be.cloud.fedoraproject.org/results/lkundrak/cnc/fedora-26-x86_64/00603081-linuxcnc/linuxcnc-2.7.9-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux