https://bugzilla.redhat.com/show_bug.cgi?id=1491492 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Blocks| |177841 (FE-NEEDSPONSOR) --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- You don't seem to be a member of the Packager Group. Please read https://fedoraproject.org/wiki/Join_the_package_collection_maintainers on how to becoming a member. You'll need a sponsor (FE-NEEDSPONSOR), introduce yourself on the fedora-devel mailing list and do informal package reviews to show a potential sponsor that you understand the Packaging Guidelines. Regarding the package itself: - That's not how you package a systemd service file. Check https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd %post /bin/systemctl --system daemon-reload %preun if [ $1 = 0 ]; then /bin/systemctl stop turnserver.service /bin/systemctl disable turnserver.service 2> /dev/null fi %postun /bin/systemctl --system daemon-reload should be: %post %systemd_user_post turnserver.service %preun %systemd_user_preun turnserver.service with a special BR: %{?systemd_requires} BuildRequires: systemd - That's not how to add a group and user: %pre %{_sbindir}/groupadd -r turnserver 2> /dev/null || : %{_sbindir}/useradd -r -g turnserver -s /bin/false -c "TURN Server daemon" -d \ %{_datadir}/%{name} turnserver 2> /dev/null || : See: https://fedoraproject.org/wiki/Packaging:UsersAndGroups You need: Requires(pre): shadow-utils Then: %pre getent group GROUPNAME >/dev/null || groupadd -r turnserver getent passwd USERNAME >/dev/null || \ useradd -r -g turnserver -d %{_datadir}/%{name} -s /sbin/nologin \ -c "TURN Server daemon" turnserver exit 0 - %defattr(-,root,root) is not needed in %files - You can use * in %files instead of listead each file one by one. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
