https://bugzilla.redhat.com/show_bug.cgi?id=1491456 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- You should talk with upstream to move tests/ to be a subdirectory of the main module, and keep the tests installed. Users might want to check the installed package too (e.g. to see if everything still works in the installed system). + package name is OK (it's a python module, but primarily an application). + license is acceptable for Fedora + license is specified correctly + BR / R / P are OK (except one nitpick, see below) + modern python packaging template is used + %python_provide is used + python3 is used + %check is present and passes + no scriptlets are necessary + %license is used You have BR: git. If you don't need a full-blown installation, git-core might be better, it provides the more-commonly used tools and has a smaller set of dependencies. You might want to extend the %description a bit, to provide a more precise description of what hatch does and how. Rpmlint ------- Checking: hatch-0.11.0-1.fc28.noarch.rpm hatch-0.11.0-1.fc28.src.rpm hatch.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy hatch.noarch: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce hatch.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/hatch/README.rst hatch.noarch: W: no-manual-page-for-binary hatch hatch.src: W: spelling-error Summary(en_US) env -> enc, en, envy hatch.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce 2 packages and 0 specfiles checked; 0 errors, 6 warnings. All OK. Rpmlint (installed packages) ---------------------------- hatch.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy hatch.noarch: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce hatch.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/hatch/README.rst hatch.noarch: W: no-manual-page-for-binary hatch 1 packages and 0 specfiles checked; 0 errors, 4 warnings. All OK. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
