https://bugzilla.redhat.com/show_bug.cgi?id=1490054 --- Comment #15 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Alexander Ploumistos from comment #13) > > > > > > > %config(noreplace) %{_sysconfdir}/scidavisrc.py > > > %exclude %{_sysconfdir}/scidavisrc.pyc > > > %exclude %{_sysconfdir}/scidavisrc.pyo > > > %exclude %{_datadir}/%{name}/scidavisUtil.pyc > > > %exclude %{_datadir}/%{name}/scidavisUtil.pyo > > > > All Python files must be installed in their related paths inside a dedicated > > python2-scidavis (and/or python3) sub-package: > > http://fedoraproject.org/wiki/Packaging:Python#Macros > > I don't understand how exactly that is supposed to work. It did seem weird > to have those python scripts there, but supposedly they are some sort of > configuration(?) files. > > Should the subpackage place them in the same locations, or do I need to > patch the makefile to get them to other paths? > > Am I to use %{__python2}, %{python2_sitelib}, %{python2_sitearch} or none of > them in this case? > > Do I need to keep the byte compiled files as well? > > Do I need extra Provides/Requires in the spec file? > > Can you point me to a package (or more) that has such a subpackage, because > I'm really lost on that one? > > > > > > > /usr/bin/update-desktop-database &> /dev/null || : > > > > Deprecated on Fedora > 25. > > I will remove it. I suppose I can ignore the update-mime-database suggested > by fedora-review as well? > > Yes. > > > > - Please, add an appdata file. > > I have submitted a file upstream, which is to be included in 1.22: > https://github.com/highperformancecoder/scidavis/pull/50 > https://github.com/highperformancecoder/scidavis/pull/52 > > I will add it to 1.21 as well. > > > > - You can avoid using %find_lang because does not work in this case. > > So I just copy the files over to %{_datadir}/%{name}/translations/ and leave > it at that, no other declaration in the %files section? Yes. > > > > - Use %doc or %{_docdir}/%{name}, not both. > > There is that CHANGES file that should go to /usr/share/doc/scidavis/ and > then there is an html manual (under construction) that gets installed there > from the makefile. If I don't use %doc, CHANGES does not get installed and > if I use > %doc CHANGES manual/index.html > I get an added index.html outside the manual directory. Should I just drop > %doc and say goodbye to the (unmaintained) CHANGES file? See attached diff files. > > > I'm willing to bet that you are starting to regret picking this up… Please > bear with me! It isn't a big deal. ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
