Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 ------- Additional Comments From petersen@xxxxxxxxxx 2007-08-08 23:59 EST ------- Here is my review: Good: + rpmlint clean + package follows naming and packaging guidelines + specifies GPL version and includes COPYING + spec file is legible + source is pristine 0d0fba8851a1ac367d7b52840e6bef3e nabi-0.18.tar.gz + builds in mock and runs correctly + buildreqs listed + uses %find_lang + file and dir ownership looks correct + consistent macro usage + does not contain devel files + scriplets reasonable Need attention: - actually thinking more, I realised that the desktop is not needed since we don't normally run input methods from the desktop menu - they should be configured with im-chooser instead. - minor, but I think ChangeLog can be dropped from %doc Apart from that all MUST items from ReviewGuidelines are satisfied. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review