[Bug 1422198] Review Request: python-docker - A Python library for the Docker Engine API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1422198



--- Comment #12 from James Hogarth <james.hogarth@xxxxxxxxx> ---
(In reply to Alan Pevec from comment #10)
> > Since the change is breaking and not compatible the Provides for
> > python-docker-py ought to be dropped from the spec before building this:
> 
> What exactly is breaking? https://pypi.python.org/pypi/docker links to the
> same old docs site https://docker-py.readthedocs.io/ so old APIs should work
> with python-docker. Is there evidence to the contrary?
> 
> > "If a package supersedes/replaces an existing package without being a
> > sufficiently compatible replacement as defined above, use only the
> > Obsoletes: line from the above example."
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1443577#c8 shows this is not
> sufficient, f25 to f26 upgrades will break with file conflicts...

Although Tomas has addressed a specific example I just wanted to note for
future reference, and others, that linking to the same readthedocs site is
never evidence for compatibility.

If you check the site you'll note that 'stable' is in the URL when you first
get to the page.

If you look carefully, bottom right in this case, there's a version selector to
pick a set of docs that matches the version of code.

If you pick a pre 2.X version of the documentation the API is very different in
places:

http://docker-py.readthedocs.io/en/1.10.0/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux