https://bugzilla.redhat.com/show_bug.cgi?id=1490054 Iwicki Artur <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Iwicki Artur <fedora@xxxxxxxxxx> --- >%{__mkdir_p} >%{__cp} -p >... "Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable." https://fedoraproject.org/wiki/Packaging:Guidelines#Macros The "x-sciprj.desktop" file is not passed through desktop-file-validate - is this intentional? Apart from those two issues, seems fine to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
