https://bugzilla.redhat.com/show_bug.cgi?id=1375380 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lkundrak@xxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |lkundrak@xxxxx Flags| |fedora-review+ --- Comment #4 from Lubomir Rintel <lkundrak@xxxxx> --- * Package named correctly * License tag okay * License good for Fedora * SPEC file clean and legible, uses up to date macros * Filelist sane * Requires/provides look good * Uses proper compiler flags * Builds fine in mock 0.) Not packaging the latest version. Probably all right since upstream doesn't do formal releases, but please bump it to a later snapshot when importing, given how long has this review been stalled rpmlint is sort of happy, but there are points that should be addressed: 1.) version-control-internal-file /usr/share/doc/icestorm/examples/*/.gitignore Please %exclude or remove this 2.) wrong-file-end-of-line-encoding /usr/share/doc/icestorm/examples/icestick/icestick.pcf Please dos2unix this. We read the examples on Linux. The above is trivial enough to be addressed on import. This package is APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
