https://bugzilla.redhat.com/show_bug.cgi?id=1489160 Robert-André Mauchin (afk until Mon 11) <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #4 from Robert-André Mauchin (afk until Mon 11) <zebob.m@xxxxxxxxx> --- First, thank you to all members of the design team for their great work. Regarding this package: - The Source0 is returning 404: https://releases.pagure.org/design/f27-backgrounds-27.0.0.tar.xz doesn't seem to exist. - Similarly, the URL: returns an empty wiki page https://fedoraproject.org/wiki/F27_Artwork - There's a mix of spaces and tabs in the SPEC, please choose one only and stick with it. (I prefer spaces). - In the source archive, there are a lot of backup files included: $find f27-backgrounds -iname "*~" f27-backgrounds/default/f26.xml~ f27-backgrounds/default/mate-backgrounds-f27.xml~ f27-backgrounds/default/mate-backgrounds-f27-animated.xml~ f27-backgrounds/default/f27.xml~ f27-backgrounds/default/f26-animated.xml~ f27-backgrounds/default/f27-animated-new.xml~ f27-backgrounds/default/f27-animated.xml~ f27-backgrounds/default/Makefile~ f27-backgrounds/default/f27-metadata.desktop.desktop~ f27-backgrounds/default/gnome-backgrounds-f27-animated.xml~ f27-backgrounds/default/gnome-backgrounds-f27.xml~ I think these file are generated as backup by Gedit, I don't think they should be included in the final archive. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
