[Bug 1488214] Review Request: deepin-manual - Deepin User Manual

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1488214

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
Hello,

  - One issue with the icon you install, you need to run gtk-update-icon-cache:

%post
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

%postun
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

    and you need to Require hicolor-icon-theme:

Requires:       hicolor-icon-theme


  - Internet access is disabled during Koji and Mock builds, thus you can't
download all the node modules required for the manual. You need to either to
bundle them. Or better: you could package them all with node2rpm, and their
dependencies… it would be a lot of work though.

List of dependencies:

  "dependencies": {
    "angular": "^1.3.15",
    "angular-animate": "^1.3.15",
    "angular-gettext": "^2.0.5",
    "angular-hotkeys": "^1.4.5",
    "babel-core": "^5.1.11",
    "babelify": "^5.0.4",
    "browserify": "^9.0.4",
    "expect.js": "^0.3.1",
    "gulp": "^3.8.11",
    "gulp-angular-gettext": "^2.1.0",
    "gulp-mocha": "^2.0.1",
    "gulp-ng-annotate": "^0.5.2",
    "gulp-rename": "^1.2.2",
    "gulp-uglify": "^1.2.0",
    "jquery": "^2.1.3",
    "marked": "^0.3.3",
    "mousetrap": "^1.5.2",
    "url-parse": "^1.0.0"
  },
  "devDependencies": {
    "gulp-sass": "^1.3.3",
    "gulp-sourcemaps": "^1.5.2"
  }

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux