[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1421055



--- Comment #9 from Peter Robinson <pbrobinson@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> Is this package really needed? The diff between gnome's cogl 1.22 and this
> fork is just a few commits. Wouldn't it be possible to cooperate with Fedora
> cogl maintainers and cogl upstream to upstream those patches and dispose of
> the fork:
> 
> Only in deepin-cogl cogl-1.22 branch:
> * 1e1e1b8a97 winsys: Disable sync_control
> * f28fe60db1 Add LICENSE
> * 9ee8ef2d2d (tag: 1.22.3) Change debian dir
> * a34f7835c0 Debian dir migration
> * 9e113c10da Add debian dir
> * d8b34ab060 texture: Support copy_sub_image
> * 78636289b0 Add GL_ARB_shader_texture_lod support
> 
> Only in upstream cogl cogl-1.22 branch:
> * cbdde65b7e (upstream/cogl-1.22) Add Nepali translation
> * 84d9ed33ef Update Malayalam translation
> * 811f285a8e Update po/Makevars
> * 3baa2d7a65 Updated Norwegian bokmål translation.
> * 0bc94d13df Update Friulian translation
> * cdb3229f54 Update Friulian translation
> * df29d85990 Add Friulian translation
> * b583e21d86 Fix an incorrect preprocessor conditional
> 
> @pbrobinson, what do you think?

Yes, absolutely, having overlapping libraries is ridiculous.

Also looking at the 7 patches in deepin-cogl listed above there's probably only
two that actually would affect Fedora, the top 5 listed commits are
debian/windows/licence related, it's likely only the bottom two of real effect
to Fedora and those should go for review upstream (well they all should).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux