[Bug 1487611] Review Request: dontpanic - Very simple library and executable used in testing Alien:: Base

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1487611



--- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #1)
> Please use a more meaningful name for your archive:
> 
> Source0:   
> https://github.com/Perl5-Alien/dontpanic/archive/%{version}/%{name}-
> %{version}.tar.gz
>
Thank you for the address. I will used it in the updated spec file.

>  - make and findutils are not needed as BR.
> 
They are called from the spec file. They are needed.

>  - dontpanic contains an rpath:
> 
> dontpanic.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dontpanic
> ['/builddir/build/BUILD/dontpanic-1.00/src/.libs']
> 
Exactly for the reason I deleted Makefile.in files. Probably something changed
in the build root and now even the regenerated files contain the -rpath option.

I still cannot figure what caused the change.

> - All build dependencies are listed in BuildRequires, except for any that
>   are listed in the exceptions section of Packaging Guidelines.
>   Note: These BR are not needed: make findutils
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

There is no exception list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux