https://bugzilla.redhat.com/show_bug.cgi?id=1481775 --- Comment #5 from Raphael Groner <projects.rg@xxxxxxxx> --- SPEC: https://raphgro.fedorapeople.org/review/py/jep/python-jep.spec SRPM: https://raphgro.fedorapeople.org/review/py/jep/python-jep-3.7.0-2.fc26.src.rpm %changelog * Sat Sep 02 2017 Raphael Groner <projects.rg@xxxxxxxx> - 3.7.0-2 - drop precompiled jar files - be more verbose about tests - add javadoc subpackage - move interpreter script into python3 subpackage - add release_notes folder to documentation - handle readme file properly Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=21618562 (In reply to Kevin Fenzi from comment #4) > 1. There's 2 jar files in the tests directory that are provided from > the upstream source. These should be removed before the build and any > tests that need them disabled. Fixed. Tests with unmet dependencies are automatically skipped. The URL [1] from sources gives me 404. Other tests can work only with python built for debug purpose what's not the case in Fedora. [1] http://www.zentus.com/sqlitejdbc/ > 2. Should javadoc be made with this package? It's optional, but > you might want to see if it's worthwhile. > http://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation Fixed. > 3. IMHO The python-jep package should be python2-jep (if you are making > the python2 version, which it looks like you are not?) > > 4. The /usr/bin/jep file should be in both python2 and python3 > subpackages, or only the python3 one if you are only shipping that > version. Right now someone could install python3-jep and have no > bin to run. Yeah, not worth an extra package for the (optional) interpreter. P.S. Sorry for the long delay! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
