https://bugzilla.redhat.com/show_bug.cgi?id=1487776 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - make %{?_smp_mflags} install DESTDIR=%{buildroot} should be replaced with the %make_install macro - Same with: make %{?_smp_mflags} → %make_build - You've got files with executable permission that shouldn't have it: wsjtx.x86_64: W: spurious-executable-perm /usr/share/doc/wsjtx/GUIcontrols.txt wsjtx.x86_64: W: spurious-executable-perm /usr/share/doc/wsjtx/jt9.txt wsjtx.x86_64: W: spurious-executable-perm /usr/share/doc/wsjtx/mouse_commands.txt wsjtx.x86_64: W: spurious-executable-perm /usr/share/doc/wsjtx/prefixes.txt wsjtx.x86_64: W: spurious-executable-perm /usr/share/doc/wsjtx/shortcuts.txt wsjtx.x86_64: W: spurious-executable-perm /usr/share/doc/wsjtx/v1.7_Features.txt wsjtx.x86_64: W: spurious-executable-perm /usr/share/doc/wsjtx/wsjtx_changelog.txt Maybe use -m 0644 with install: install -m 0644 -p -t %{buildroot}%{_datadir}/doc/%{name} GUIcontrols.txt jt9.txt \ mouse_commands.txt prefixes.txt shortcuts.txt v1.7_Features.txt \ wsjtx_changelog.txt - Similarly you've got files with Windows line ending: wsjtx.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/wsjtx/GUIcontrols.txt wsjtx.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/wsjtx/prefixes.txt wsjtx.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/wsjtx/wsjtx_changelog.txt Switch them to UNIX line endings by adding *.txt to your dos2unix command: dos2unix *.ui *.iss *.rc *.txt - mock fails to verify the certificate of https://physics.princeton.edu : wsjtx.src: W: invalid-url URL: https://physics.princeton.edu/pulsar/k1jt/wsjtx.html <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:748)> wsjtx.src: W: invalid-url Source0: https://physics.princeton.edu/pulsar/k1jt/wsjtx-1.8.0-rc1.tgz <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:748)> Switch to http if the problem persists. - /usr/share/doc/wsjtx/INSTALL shouldn't be included in %doc - Rpmlint warns about jt9 having executable stack: executable-stack: The binary declares the stack as executable. Executable stack is usually an error as it is only needed if the code contains GCC trampolines or similar constructs which uses code on the stack. One common source for needlessly executable stack cases are object files built from assembler files which don't define a proper .note.GNU-stack section. You can remove it with: BuildRequires: execstack Then below make install: %make_install execstack -c %{buildroot}%{_bindir}/jt9 - There's an issue while installing the package: Error: Transaction check error: file /usr/lib/.build-id/5d/1c3c62276031587a6ac333785ee12f62218a86 conflicts between attempted installs of wsjtx-1.8.0-0.1.rc1.fc28.x86_64 and hamlib-3.1-8.fc28.x86_64 file /usr/lib/.build-id/d3/602e131e4dc419e24969dd19b48829ff695210 conflicts between attempted installs of wsjtx-1.8.0-0.1.rc1.fc28.x86_64 and hamlib-3.1-8.fc28.x86_64 I am not sure what's causing this, I've asked for help on fedora-devel. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
