[Bug 1487419] Review Request: wsprx - Weak Signal Propagation Reporter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1487419

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
Hello,


Additionally:

 - You can replace make %{?_smp_mflags} install DESTDIR=%{buildroot} with
%make_install
 - make %{?_smp_mflags} → %make_build

 - Why do you make a -doc subpackage for a single file? Just include it in the
%doc directive:

%files
%doc WSPR-X_Users_Guide.pdf

 - Why do you want to convert the docx to a PDF? And why do you pull
Libreoffice Writer (which is a huge dependency) to just do that?

If you feel necessary to join the help in PDF, I think it would be better to
add it as Source1 with a comment on how you converted it. (for that I suggest
you to also look at pandoc, a command line tool to convert to and from multiple
format).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux