https://bugzilla.redhat.com/show_bug.cgi?id=1487430 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial pass through: > # Generate devel rpm > %global with_devel 0 Why is this disabled? Is it not possible to use Git LFS code as a module in other Go programs? > # Generate unit-test rpm > %global with_unit_test 0 Why is this disabled? > %post > /bin/git-lfs install --system Please use "%{_bindir}/%{name}" here, as that's how it is actually installed. > %preun > if [ $1 -gt 0 ]; then > /bin/git-lfs uninstall > fi > exit 0 Same here, and also properly indent the shell script here. > %files > %license LICENSE.md > %{_bindir}/%{name} > %doc %{_mandir}/man1/%{name}*.1* > %doc %{_mandir}/man5/%{name}*.5* It is redundant to declare man pages as documentation, as rpm auto-marks files installed into %{_mandir}/*/* as documentation files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
