https://bugzilla.redhat.com/show_bug.cgi?id=1238383 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, I saw your message on fedora-devel, I will process some of your packages, it will give an excellent excuse to learn Mingw guidelines: https://fedoraproject.org/wiki/Packaging:MinGW This one needs some refreshing. First of all, Google code is no longer a thing, the project was moved to Github, and the latest version is 1.2rc: URL: https://github.com/qextserialport/qextserialport Source0: https://github.com/qextserialport/qextserialport/archive/%{version}rc/%{name}-%{version}rc.tar.gz Then, don't forget to fix %prep: %prep %setup -q -n %{pkgname}-%{version}rc One patch need to be updated as .pro files got centralized in the rc: diff -up qextserialport-1.2rc/qextserialport.pro.releasebuild qextserialport-1.2rc/qextserialport.pro --- qextserialport-1.2rc/qextserialport.pro.releasebuild 2012-12-13 06:23:03.000000000 +0100 +++ qextserialport-1.2rc/qextserialport.pro 2017-08-31 18:09:16.702115120 +0200 @@ -57,8 +57,6 @@ macx:qesp_mac_framework { QMAKE_BUNDLE_DATA += FRAMEWORK_HEADERS } -win32|mac:!wince*:!win32-msvc:!macx-xcode:CONFIG += debug_and_release build_all - #For non-windows system, only depends on QtCore module unix:QT = core else:QT = core gui The other patch seems not to be relevant anymore. - Use Qt5 instead of Qt4, otherwise you'll encounter a bug of missing private includes and you'll need to make a MingW package of qt-devel-private: BuildRequires: mingw32-filesystem >= 95 BuildRequires: mingw32-gcc-c++ BuildRequires: mingw32-qt5-qmake BuildRequires: mingw64-filesystem >= 95 BuildRequires: mingw64-gcc-c++ BuildRequires: mingw64-qt5-qmake Then: %build %mingw_qmake_qt5 .. And: # Fix library names and installation folders mkdir -p %{buildroot}%{mingw32_bindir} mv %{buildroot}%{mingw32_libdir}/Qt5ExtSerialPort1.dll %{buildroot}%{mingw32_bindir}/Qt5ExtSerialPort1.dll mkdir -p %{buildroot}%{mingw64_bindir} mv %{buildroot}%{mingw64_libdir}/Qt5ExtSerialPort1.dll %{buildroot}%{mingw64_bindir}/Qt5ExtSerialPort1.dll Finally: %files -n mingw32-%{pkgname} %license LICENSE %{mingw32_bindir}/Qt5ExtSerialPort1.dll %{mingw32_libdir}/libQt5ExtSerialPort1.dll.a %{mingw32_libdir}/Qt5ExtSerialPort.prl %{mingw32_datadir}/qt5/mkspecs/features/extserialport.prf %{mingw32_includedir}/qt5/QtExtSerialPort/ %files -n mingw64-%{pkgname} %license LICENSE %{mingw64_bindir}/Qt5ExtSerialPort1.dll %{mingw64_libdir}/libQt5ExtSerialPort1.dll.a %{mingw64_libdir}/Qt5ExtSerialPort.prl %{mingw64_datadir}/qt5/mkspecs/features/extserialport.prf %{mingw64_includedir}/qt5/QtExtSerialPort/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
