Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: junit4 - java regression testing framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247513 vivekl@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fnasser@xxxxxxxxxx ------- Additional Comments From vivekl@xxxxxxxxxx 2007-08-06 23:07 EST ------- (In reply to comment #4) > New files: > > http://bagu.org/eclipse/junit4.spec > http://bagu.org/eclipse/junit4-4.3.1-1jpp.2.fc8.src.rpm > Thanks and sorry for the delay. I dont think you need to bump the release for this, but whatever :) This is probably really nit-picky but I recommend using the %define _with_gcj_support 0 up top to disable aot compilation for the moment if you want to. So you wont have to comment out ownership under the %{_libdir}/gcj etc. and once the bugs in gcj are fixed simply switching the gcj_support thing would do. Also, it seems that the version of spec-gcj-convert used to build the spec has bugs: %postun %if %{gcj_support} ... %endif while it really should be: %if %{gcj_support} %postun ... %endif This leaves empty script sections when gcj support is disabled by default - which is the case in jpackage and currently, due to the said gcj bug for Fedora as well. Adding fnasser to CC since he is going to handle the push of the package to jpackage. NEEDSWORK: See above -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review