https://bugzilla.redhat.com/show_bug.cgi?id=1480794 --- Comment #3 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- Thanks for the review! I don't wish to sound ungrateful, but I think you missed something: > %define libname %(echo %{name} | sed -e 's/^ocaml-//') It is preferred to use "global" over "define" for this sort of thing: https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define However, the OCaml package template (rpmdev-newspec -t ocaml), like most of those templates, is sadly out of date and still uses %define, and I forgot to change it before submitting the first batch of reviews. I meant to update this submission too, but didn't get around to it before you reviewed the package. :) I will fix this (and the other things you mentioned) on import. But I wanted to say something here so you're aware that this is something to look for in other package reviews. Anyway, thanks again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
