https://bugzilla.redhat.com/show_bug.cgi?id=1475750 --- Comment #7 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Thanks for your review. > - What is the purpose of the unit-test-devel subpackage? I'm not sure I understand the usefulness of packaging the unit tests. It is how Golang libraries are supposed to be packaged. See https://koji.fedoraproject.org/koji/search?match=glob&type=rpm&terms=*unit-test-devel* All of these Golang libraries SPECs are generated by Gofed, the script recommended in Golang Draft Guidelines. > - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/gocode/src/bazil.org/fuse See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles Removed. > - I believe the license field should include MIT as well (see the section in LICENSE that refers to fuse.go which appears to be MIT license). I've added the reference to fuse.go under MIT. > - Package doesn't own /usr/share/gocode/src/bazil.org directory. No, because this directory is not specific to this package, it is shared with other Go project from Bazil. If I were to package golang-bazil-zipfs for example, I would also use /usr/share/gocode/src/bazil.org. The only specific directory are the ones one level below, for example /usr/share/gocode/src/bazil.org/fuse or /usr/share/gocode/src/bazil.org/zipfs SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00594632-golang-bazil-fuse/golang-bazil-fuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00594632-golang-bazil-fuse/golang-bazil-fuse-0-0.1.20160811.git371fbbd.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
