https://bugzilla.redhat.com/show_bug.cgi?id=1485721 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - You need to validate the desktop file you install: BuildRequires: desktop-file-utils %check desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name} .desktop - You install hi-colors icons so you need to run gtk-update-icon-cache See https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GTK.2B_icon_cache Requires: hicolor-icon-theme %post /sbin/ldconfig touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ] ; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi %postun /sbin/ldconfig touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ] ; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi - Please use pkgconfig where you can: BuildRequires: pkgconfig(gnome-desktop-3.0) BuildRequires: pkgconfig(granite) BuildRequires: vala BuildRequires: vala-tools BuildRequires: pkgconfig(libbamf3) BuildRequires: pkgconfig(clutter-gtk-1.0) BuildRequires: pkgconfig(libdeepin-mutter) BuildRequires: pkgconfig(upower-glib) BuildRequires: pkgconfig(gee-0.8) BuildRequires: pkgconfig(gudev-1.0) BuildRequires: pkgconfig(libwnck-3.0) BuildRequires: pkgconfig(libcanberra) BuildRequires: pkgconfig(xkbcommon-x11) BuildRequires: pkgconfig(xkbfile) - I'm missing deepin-mutter. Could you propose this package for a Review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
