https://bugzilla.redhat.com/show_bug.cgi?id=1450144 --- Comment #3 from František Dvořák <valtri@xxxxxxxxxx> --- Thanks for the review! (In reply to Robert-André Mauchin from comment #1) > - There's two almost identical BR: > > BuildRequires: rubygem(rspec) > BuildRequires: rubygem(rspec) >= 3 > > Just keep the later one with the version requirement. > You're right, fixed. > - There's an examples/ directory in the source files, it would be great to > include it in %doc: > > %files > %doc examples > Examples are in the -doc subpackage, but they has not been marked as %doc. Fixed. > > - According to the guidelines for Rubygems > (https://fedoraproject.org/wiki/Packaging:Ruby#RubyGems): > > "There should not be Requires: ruby(release), unless you want to explicitly > specify Ruby version compatibility. Automatically generated dependency on > RubyGems (Requires: ruby(rubygems)) is enough" > > So, you should probably remove Requires: ruby(release) but instead add a > Requires: ruby(rubygems) Actually this is not a runtime dependency, only BuildRequires. But it is true the explicit "BuildRequires: ruby(release)" is probably not needed here (ruby interpreter is picked by rubygems package already, and ruby is not launched directly in the spec file). Removed. The new version: Spec URL: http://scientific.zcu.cz/fedora/rubygem-yell-2.0.7-2/rubygem-yell.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-yell-2.0.7-2/rubygem-yell-2.0.7-2.fc25.src.rpm * Sun Aug 27 2017 František Dvořák <valtri@xxxxxxxxxx> - 2.0.7-2 - Better build dependencies - Mark examples as documentation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
